use spotify client parameters from config.ini#21
Closed
wolfmanx wants to merge 1 commit intoSolidEva:masterfrom
Closed
use spotify client parameters from config.ini#21wolfmanx wants to merge 1 commit intoSolidEva:masterfrom
wolfmanx wants to merge 1 commit intoSolidEva:masterfrom
Conversation
|
Thank you SO MUCH for collecting all of these important fixes into a single repository; I was really hoping someone would do this. Extremely helpful as SolidHal seems to be unavailable to accept pull requests currently |
Owner
|
I had used environment vars as I run this in a docker. With docker, environmental variables can be easily modified externally from the running environment. Closing this pull request, reference my comment on: #23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is awkward to use environment variables in a standlone python program. This PR allows to put the client credentials into
config.ini.This PR is added as reference for users who wish to get certain fixes without the need for @SolidHal to accept these PRs any time soon. This PR is collected in branch wolfmanx/spotify-ripper/pr-collect, which can be used to get a version with all fixes and enhancements.